Skip to content

Clean up and improve lab_sim objectives#526

Open
davetcoleman wants to merge 3 commits intomainfrom
dave/close-gripper-force-success
Open

Clean up and improve lab_sim objectives#526
davetcoleman wants to merge 3 commits intomainfrom
dave/close-gripper-force-success

Conversation

@davetcoleman
Copy link
Member

@davetcoleman davetcoleman commented Mar 5, 2026

Summary

  • Wrap Open/Close Gripper in ForceSuccess instead of Sequence
  • Replace _Scan Scene and Scan Multiple Views with Scan Scene - Multiple Point Clouds
  • Rename Stack Blocks with ICP to Stack Objects with ICP
  • Rename show_grasp_link to Visualize Grasp Link
  • Remove Pick And Place Example (superseded)
  • Recategorize pick/place subtrees to Manipulation
  • Remove redundant _favorite="false" from subtrees
  • Make Move Along Square runnable

Test plan

  • Run Close Gripper / Open Gripper and verify ForceSuccess prevents timeout failures
  • Run Scan Scene - Multiple Point Clouds
  • Verify renamed objectives load correctly

🤖 Generated with Claude Code

@davetcoleman davetcoleman force-pushed the dave/close-gripper-force-success branch from b41294e to f45f423 Compare March 5, 2026 00:37
@davetcoleman davetcoleman changed the title Wrap Close Gripper in ForceSuccess instead of Sequence Clean up and improve lab_sim objectives Mar 5, 2026
@davetcoleman davetcoleman requested a review from nbbrooks March 5, 2026 00:43
@davetcoleman davetcoleman marked this pull request as ready for review March 5, 2026 00:43
@davetcoleman davetcoleman force-pushed the dave/close-gripper-force-success branch 2 times, most recently from 8d03c59 to 87861a3 Compare March 5, 2026 00:49
@JWhitleyWork JWhitleyWork force-pushed the dave/close-gripper-force-success branch from 87861a3 to 2ccfe12 Compare March 5, 2026 18:10
@JWhitleyWork
Copy link
Member

Rebased to pick up CI fix.

@davetcoleman davetcoleman force-pushed the dave/close-gripper-force-success branch 3 times, most recently from d56518f to 53d8921 Compare March 9, 2026 23:29
_favorite="false"
>
<Control ID="Sequence" name="root">
<Decorator ID="ForceSuccess">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this an intentional change? I thought the new objects and grasp poses were allowing the stall torque setting to report grip success.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this was a sequence with 1 child, which was silly.

then i added force success because many times it would stall out even though it had a fine grip. i think the new medicine bottles i added are wider, so the previous numbers wouldn't work well for them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont understand why the stall setting isn't triggering a success...maybe it is not working? https://github.com/PickNikRobotics/moveit_pro_example_ws/blob/main/src/lab_sim/config/control/picknik_ur.ros2_control.yaml#L93-L94

If we make this force success change as a bandaid for lab_sim training because perhaps underpowered systems are having mujoco perf problems, I am ok with that, but we should prob also reduce the timeout so people aren't waiting 15sec for a gripper call to end.

Copy link
Member

@nbbrooks nbbrooks Mar 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps setting a non-default stall_velocity_threshold will make the stall feature work? by default it is 0.001 and maybe we need it to be more like 0.01

See https://control.ros.org/humble/doc/ros2_controllers/gripper_controllers/doc/userdoc.html#gripper-action-controller

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or perhaps we dont have the mujoco gripper configured to report velocity. I would do ros2 topic echo /joint_states and make sure there is a vel field for the robotiq_85_left_knuckle_joint

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simplescreenrecorder-2026-03-11_15.08.17.mp4

I collected some plotjuggler data to see what is going on

davetcoleman and others added 2 commits March 11, 2026 14:01
- Wrap Open/Close Gripper in ForceSuccess instead of Sequence
- Replace _Scan Scene and Scan Multiple Views with Scan Scene - Multiple Point Clouds
- Rename Stack Blocks with ICP to Stack Objects with ICP
- Rename show_grasp_link to Visualize Grasp Link
- Remove Pick And Place Example (superseded)
- Recategorize pick/place subtrees to Manipulation
- Remove redundant _favorite="false" from subtrees
- Make Move Along Square runnable

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Rename "Above Pick Cube" to "Above Pick Object" in ur_waypoints.yaml
to match the updated objective references.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@nbbrooks nbbrooks force-pushed the dave/close-gripper-force-success branch from 53d8921 to 971fd08 Compare March 11, 2026 20:01
@nbbrooks
Copy link
Member

rebased to pull in dependency fix

@nbbrooks
Copy link
Member

@davetcoleman the Force Success may no longer be necessary, I have tuned the stall velocity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants